linux-mips
[Top] [All Lists]

Re: rfc about an uncommented string

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: rfc about an uncommented string
From: Fuxin Zhang <fxzhang@ict.ac.cn>
Date: Mon, 10 Oct 2005 19:23:19 +0800
Cc: Carlo Perassi <carlo@linux.it>, linux-mips@linux-mips.org
In-reply-to: <20051010111149.GC2661@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20051009134106.GB9091@voyager> <20051010111149.GC2661@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
We are using 8172 for 2.4 kernels presently,although may drop it
sometime later.

I don't read the 2.6 code,but it seems it remains the same as the copy
in 2.4(except that #ifdef changes).I can't see why the code is broken?
In case you mean the ioport address,mips_io_port_base for that board is
0xa0000000, inb(0x14000060) is reading from 0xb4000060, which is correct
for it.

Ralf Baechle wrote:
> On Sun, Oct 09, 2005 at 03:41:06PM +0200, Carlo Perassi wrote:
> 
> 
>>Hi.
>>As suggested (*) by Arthur Othieno on the kernel-janitors mailing list,
>>I bounce here this email for collecting comments.
>>The old email refers to 2.6.13-rc6 but the code is still the same on
>>2.6.14-rc3.
>>Thank you.
>>
>>Hi.
>>
>>I'd like to collect some comments about the following code
>>segment I found in
>>linux-2.6.13-rc6/arch/mips/ite-boards/generic/it8172_setup.c
>>(the "^^^" sequence is not mine, it's in the code)
> 
> 
> I know, I put it there.  The code was obviously broken, so I place this
> hard to miss not right into the middle of it.  It's there since ages and
> nobody did complain.  So unless somebody complains - and that complaint
> better include some patches - I will delete support for the IT8172 and
> it's eval board.
> 
>   Ralf
> 
> 
> 

<Prev in Thread] Current Thread [Next in Thread>