linux-mips
[Top] [All Lists]

rfc about an uncommented string

To: linux-mips@linux-mips.org
Subject: rfc about an uncommented string
From: Carlo Perassi <carlo@linux.it>
Date: Sun, 9 Oct 2005 15:41:06 +0200
Original-recipient: rfc822;linux-mips@linux-mips.org
Reply-to: carlo@linux.it
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.11
Hi.
As suggested (*) by Arthur Othieno on the kernel-janitors mailing list,
I bounce here this email for collecting comments.
The old email refers to 2.6.13-rc6 but the code is still the same on
2.6.14-rc3.
Thank you.

Hi.

I'd like to collect some comments about the following code
segment I found in
linux-2.6.13-rc6/arch/mips/ite-boards/generic/it8172_setup.c
(the "^^^" sequence is not mine, it's in the code)

#ifdef CONFIG_SERIO_I8042
/*
 * According to the ITE Special BIOS Note for waking up the
 * keyboard controller...
 */
static int init_8712_keyboard(void)
{
        unsigned int cmd_port = 0x14000064;
        unsigned int data_port = 0x14000060;
                                 ^^^^^^^^^^^
        Somebody here doesn't grok the concept of io ports.

(*)
http://lists.osdl.org/pipermail/kernel-janitors/2005-August/004704.html
http://lists.osdl.org/pipermail/kernel-janitors/2005-August/004705.html
http://lists.osdl.org/pipermail/kernel-janitors/2005-August/004707.html
http://lists.osdl.org/pipermail/kernel-janitors/2005-October/004955.html

-- 
Carlo Perassi - http://www.linux.it/~carlo/

<Prev in Thread] Current Thread [Next in Thread>