[Top] [All Lists]

Re: [PATCH] Add support for 4KS cpu.

To: Franck <>
Subject: Re: [PATCH] Add support for 4KS cpu.
From: "Maciej W. Rozycki" <>
Date: Tue, 4 Oct 2005 14:54:20 +0100 (BST)
Cc: Ralf Baechle <>,
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <>
On Tue, 4 Oct 2005, Franck wrote:

> >  Please send patches inline.
> I can see it inlined...what email viewer are you using ?

 Well, inlined means straight in the body rather than as a MIME attachment 
-- even if you use "Content-Disposition: inline", it's still one.

> True, but we may have some differences in future. For example, they
> both implements smart mips instructions. See options passed to GCC in
> mips Makefile, they're different from CPU_MIPS32_R2 ones. They also
> have a couple of instructions very useful for cryptographic

 See my other comment in this thread.  As to the SmartMIPS/crypto 
instructions -- unless they are going to be emitted by GCC for the kernel 
build (which I seriously doubt), there is no point in enabling them.

> algorithms. And have some extra bits in TLB to protect pages from
> being execute for example. These are the main differences that I can

 Now that may be of potential interest of the kernel, but again, that's in 
principle probably not specific to these processors, so that should be a 
separate option; if possible one selected at the run time only (hint, 

> remember. Big fat warning: I sent all support I have done for these
> cpu, _not_ more, _not_ less. I agree it's almost nothing but it's a
> start...

 Well, it's probably a bit too early for inclusion, but it's certainly not 
for a review.  By sending changes here for discussion early you may avoid 
a lot of hassle later when you may discover a major update is required for 
them to be accepted.  Good luck!


<Prev in Thread] Current Thread [Next in Thread>