linux-mips
[Top] [All Lists]

Re: [PATCH] Add support for 4KS cpu.

To: Franck <vagabon.xyz@gmail.com>
Subject: Re: [PATCH] Add support for 4KS cpu.
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Tue, 4 Oct 2005 12:34:12 +0100 (BST)
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <cda58cb80510040149p690397afo@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cda58cb80510040149p690397afo@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 4 Oct 2005, Franck wrote:

> This patch adds support for both 4ksc and 4ksd cpus. These cpu are
> mainly used in embedded system such as smartcard or point of sell
> devices as they provide some extra security features.

 Please send patches inline.

 Apart from the change to "arch/mips/kernel/cpu-probe.c", which is useful, 
what's the benefit of the changes?  Specifically how is selecting e.g. 
"CPU_4KSC" meant to be different from "CPU_MIPS32_R2"?  Do you want to 
make GCC tune your code according to a specific's CPU pipeline 
description?  If so, then it should probably be done a bit differently and 
there is actually no need to differentiate between specific members of the 
4K family.

> Signed-off-by: Franck <vagabon.xyz@gmail.com>

 You should rather use your real name here.  [Hmm, why am I responding to 
an anonym in the first place?...]

  Maciej

<Prev in Thread] Current Thread [Next in Thread>