linux-mips
[Top] [All Lists]

Re: [patch] db1550: useless memset() call

To: kbaidarov <kbaidarov@dev.rtsoft.ru>
Subject: Re: [patch] db1550: useless memset() call
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 30 Sep 2005 23:19:09 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <43329632.8070400@dev.rtsoft.ru>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <43329632.8070400@dev.rtsoft.ru>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Thu, Sep 22, 2005 at 03:32:02PM +0400, kbaidarov wrote:

> I've try kernel without memset() on the board - is ok, board boot.
> All drivers works fine. Than I grep the kernel sources:
> 
> [root@windmill linux]# grep -nri "memset(irq_desc" arch/
> arch/mips/au1000/common/irq.c:449:      memset(irq_desc, 0, 
> sizeof(irq_desc));
> arch/mips/ite-boards/generic/irq.c:184:        memset(irq_desc, 0, 
> sizeof(irq_desc));
> [root@windmill linux]#
> 
> Only 2 matches! Does we needs memset() at all?
> And if some one try to initialize irq_desc from start_kernel() before 
> arch_init_irq() call, then following arch_init_irq() call discard all that 
> initialization.

Exactly, so the initialization is wrong, so I'm removing both calls.

Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [patch] db1550: useless memset() call, Ralf Baechle <=