linux-mips
[Top] [All Lists]

[patch] cfi: removed warning message on expected behaivor

To: <linux-mips@linux-mips.org>
Subject: [patch] cfi: removed warning message on expected behaivor
From: "Jan Pedersen" <jan.pedersen@glaze.dk>
Date: Tue, 27 Sep 2005 21:45:53 +0200
Importance: Low
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
Thread-index: AcXDnBGyK+lQCz6NQgKmvZ2YSgbPWg==
When an erase operation is in progress, the DQ5 (data bit 5 / exceeded
timing limit) pin on the flash chips may raise just before operation
complete is detected. This is expected behaivor because when the erase is
complete, DQ5 switches from 'exceeded timing limit' to 'data bit 5' which
therefore might be read as '1' just before operation complete is detected.
This fix is well tested.

Signed-off-by: Jan Pedersen <jp@jp-embedded.com>
---
diff -Naur linux-2.4.31.org/drivers/mtd/chips/cfi_cmdset_0002.c
linux-2.4.31/drivers/mtd/chips/cfi_cmdset_0002.c
--- linux-2.4.31.org/drivers/mtd/chips/cfi_cmdset_0002.c        2004-11-17
06:54:21.000000000 -0500
+++ linux-2.4.31/drivers/mtd/chips/cfi_cmdset_0002.c    2005-08-22
12:14:17.000000000 -0400
@@ -950,12 +950,8 @@
                    oldstatus   = cfi_read( map, adr );
                    status      = cfi_read( map, adr );
                    
-                   if( ( oldstatus & 0x00FF ) == ( status & 0x00FF ) )
+                   if( ( oldstatus & 0x00FF ) != ( status & 0x00FF ) )
                    {
-                printk( "Warning: DQ5 raised while erase operation was in
progress, but erase completed OK\n" );              
-                   }                   
-                       else
-            {
                            /* DQ5 is active so we can do a reset and stop
the erase */
                                cfi_write(map, CMD(0xF0), chip->start);
                 printk( KERN_WARNING "Internal flash device timeout occured
or write operation was performed while flash was erasing\n" );




<Prev in Thread] Current Thread [Next in Thread>
  • [patch] cfi: removed warning message on expected behaivor, Jan Pedersen <=