linux-mips
[Top] [All Lists]

[patch] db1550: useless memset() call

To: linux-mips@linux-mips.org
Subject: [patch] db1550: useless memset() call
From: kbaidarov <kbaidarov@dev.rtsoft.ru>
Date: Thu, 22 Sep 2005 15:32:02 +0400
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050719 Fedora/1.7.10-1.3.1
I've try kernel without memset() on the board - is ok, board boot.
All drivers works fine. Than I grep the kernel sources:

[root@windmill linux]# grep -nri "memset(irq_desc" arch/
arch/mips/au1000/common/irq.c:449:      memset(irq_desc, 0, sizeof(irq_desc));
arch/mips/ite-boards/generic/irq.c:184:        memset(irq_desc, 0, 
sizeof(irq_desc));
[root@windmill linux]#

Only 2 matches! Does we needs memset() at all?
And if some one try to initialize irq_desc from start_kernel() before 
arch_init_irq() call, then following arch_init_irq() call discard all that 
initialization.

Description:
Removes useless memset() call.
Signed-off-by: Konstantin Baydarov<kbaidarov@dev.rtsoft.ru>

Index: linux_up/linux/arch/mips/au1000/common/irq.c
===================================================================
--- linux_up.orig/linux/arch/mips/au1000/common/irq.c
+++ linux_up/linux/arch/mips/au1000/common/irq.c
@@ -446,7 +446,6 @@ void __init arch_init_irq(void)
        extern int au1xxx_ic0_nr_irqs;
 
        cp0_status = read_c0_status();
-       memset(irq_desc, 0, sizeof(irq_desc));
        set_except_vector(0, au1000_IRQ);
 
        /* Initialize interrupt controllers to a safe state.
<Prev in Thread] Current Thread [Next in Thread>
  • [patch] db1550: useless memset() call, kbaidarov <=