[Top] [All Lists]

Re: a patch for generic MIPS RTC

Subject: Re: a patch for generic MIPS RTC
From: Atsushi Nemoto <>
Date: Mon, 05 Sep 2005 22:45:34 +0900 (JST)
In-reply-to: <>
Original-recipient: rfc822;
References: <1124355290.5441.45.camel@localhost.localdomain> <> <>
>>>>> On Mon, 5 Sep 2005 12:08:34 +0100 (BST), "Maciej W. Rozycki" 
>>>>> <> said:

macro>  That's how other architectures do this, see e.g.
macro> "arch/alpha/kernel/time.c".  Why should we be different, even
macro> for now?

Please elaborate more ?  Do you mean we should implement default
rtc_set_mmss() and take the rtc_lock in it ?  Or do you mean we should
take rtc_lock in each board-dependent rtc_set_time/rtc_set_time ?  

macro> Also the call is named rtc_set_mmss() for an unknown reason
macro> while all the others have set_rtc_mmss().

IIRC, you are (one of) the godfather of the function, aren't you?  :-)

Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>