linux-mips
[Top] [All Lists]

Re: a patch for generic MIPS RTC

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: a patch for generic MIPS RTC
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Mon, 5 Sep 2005 12:08:34 +0100 (BST)
Cc: spodstavin@ru.mvista.com, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20050905.135422.112260934.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1124355290.5441.45.camel@localhost.localdomain> <20050905.135422.112260934.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 5 Sep 2005, Atsushi Nemoto wrote:

> 3. We should protect rtc_set_mmss() call during get_rtc_time or
>    set_rtc_time (this is not your patch's fault).
> 
> How about this patch?  The rtc_lock could be manipulated in each
> RTC-dependent routines, but I choose a simple way for now.

 That's how other architectures do this, see e.g. 
"arch/alpha/kernel/time.c".  Why should we be different, even for now?  
Also the call is named rtc_set_mmss() for an unknown reason while all the 
others have set_rtc_mmss().

  Maciej

<Prev in Thread] Current Thread [Next in Thread>