linux-mips
[Top] [All Lists]

Re: [PATCH] casts in TLB macros

To: Andrew Isaacson <adi@broadcom.com>
Subject: Re: [PATCH] casts in TLB macros
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Wed, 17 Aug 2005 11:02:23 +0100 (BST)
Cc: linux-mips@linux-mips.org
In-reply-to: <20050817030608.GM24444@broadcom.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20050817030608.GM24444@broadcom.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 16 Aug 2005, Andrew Isaacson wrote:

> @@ -748,7 +748,7 @@
>  do {                                                                 \
>       __asm__ __volatile__(                                           \
>               "ctc0\t%z0, " #register "\n\t"                          \
> -             : : "Jr" ((unsigned int)value));                        \
> +             : : "Jr" (unsigned int)(value));                        \
>  } while (0)
>  
>  /*

 I'm surprised it works, but please don't drop the outer brackets in asm 
operands anyway.  Otherwise it's an obvious fix, thanks.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>