linux-mips
[Top] [All Lists]

Re: CVS Update@linux-mips.org: linux

To: Thiemo Seufer <ths@networkno.de>
Subject: Re: CVS Update@linux-mips.org: linux
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 22 Jul 2005 09:06:55 -0400
Cc: linux-mips@linux-mips.org
In-reply-to: <20050722121030.GD1692@hattusa.textio>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20050721153359Z8225218-3678+3745@linux-mips.org> <20050722043057.GA3803@linux-mips.org> <20050722121030.GD1692@hattusa.textio>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Fri, Jul 22, 2005 at 02:10:30PM +0200, Thiemo Seufer wrote:
> Date: Fri, 22 Jul 2005 14:10:30 +0200
> To:   Ralf Baechle <ralf@linux-mips.org>
> Cc:   linux-mips@linux-mips.org
> Subject: Re: CVS Update@linux-mips.org: linux
> Content-Type: text/plain; charset=us-ascii
> From: Thiemo Seufer <ths@networkno.de>
> 
> Ralf Baechle wrote:
> > On Thu, Jul 21, 2005 at 04:33:53PM +0100, ths@linux-mips.org wrote:
> > 
> > > Modified files:
> > >   arch/mips/kernel: binfmt_elfo32.c 
> > >   include/asm-mips: elf.h 
> > > 
> > > Log message:
> > >   Fix ELF defines: EF_* is a field, E_* a distinct flag therein.
> > 
> > Remarkably bad idea after the old definitions are already being used since
> > over a decade.
> 
> Well, kernel headers are less widely used than others, and everywhere
> else it is E_*. Since
>  - kernel headers in general aren't meant as an interface for userland,
>  - the definition is inconsistent to the userland one,

Glibc is the only thing elf.h that defines the E_* names at all and
explicitly says "don't use".

>  - the in-kernel use seems to be limited to the ELF binary object
>    loader and probably third party modules loaders
> I found moving to a consistent definition to be more useful than
> keeping the old inconsistent one.

I think you're confusing binutils's internal definitions with the use
everywhere else.

Mind pulling that patch?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>