linux-mips
[Top] [All Lists]

Re: CVS Update@linux-mips.org: linux

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: CVS Update@linux-mips.org: linux
From: Thiemo Seufer <ths@networkno.de>
Date: Fri, 22 Jul 2005 14:10:30 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <20050722043057.GA3803@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20050721153359Z8225218-3678+3745@linux-mips.org> <20050722043057.GA3803@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.9i
Ralf Baechle wrote:
> On Thu, Jul 21, 2005 at 04:33:53PM +0100, ths@linux-mips.org wrote:
> 
> > Modified files:
> >     arch/mips/kernel: binfmt_elfo32.c 
> >     include/asm-mips: elf.h 
> > 
> > Log message:
> >     Fix ELF defines: EF_* is a field, E_* a distinct flag therein.
> 
> Remarkably bad idea after the old definitions are already being used since
> over a decade.

Well, kernel headers are less widely used than others, and everywhere
else it is E_*. Since
 - kernel headers in general aren't meant as an interface for userland,
 - the definition is inconsistent to the userland one,
 - the in-kernel use seems to be limited to the ELF binary object
   loader and probably third party modules loaders
I found moving to a consistent definition to be more useful than
keeping the old inconsistent one.


Thiemo

<Prev in Thread] Current Thread [Next in Thread>