linux-mips
[Top] [All Lists]

Re: CVS Update@linux-mips.org: linux

To: Richard Sandiford <richard@codesourcery.com>
Subject: Re: CVS Update@linux-mips.org: linux
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Fri, 8 Jul 2005 16:59:56 +0100 (BST)
Cc: Ralf Baechle DL5RB <ralf@linux-mips.org>, Thiemo Seufer <ths@networkno.de>, linux-mips@linux-mips.org
In-reply-to: <87pstt4891.fsf@talisman.home>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20050707091937Z8226163-3678+1737@linux-mips.org> <Pine.LNX.4.61L.0507071227170.3205@blysk.ds.pg.gda.pl> <20050707121235.GV1645@hattusa.textio> <Pine.LNX.4.61L.0507071314010.3205@blysk.ds.pg.gda.pl> <20050707122226.GW1645@hattusa.textio> <Pine.LNX.4.61L.0507071356450.3205@blysk.ds.pg.gda.pl> <20050707162959.GQ2822@linux-mips.org> <87zmsx4do1.fsf@talisman.home> <Pine.LNX.4.61L.0507081553040.25104@blysk.ds.pg.gda.pl> <87pstt4891.fsf@talisman.home>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 8 Jul 2005, Richard Sandiford wrote:

> > 2005-07-08  Maciej W. Rozycki  <macro@mips.com>
> >
> >     * config/mips/linux.h (CC1_SPEC): Override defaults from
> >     config/linux.h.
> 
> Looks reasonable, but I think you should just set SUBTARGET_CC1_SPEC
> to the normal linux.h definition of CC1_SPEC.  There shouldn't be
> any need to redefine CC1_SPEC itself (with all the mips.h duplication
> that that implies).  It'll be easier to keep things in sync that way.

 The problem is config/linux.h defines CC1_SPEC before config/mips.h is 
included and as a result the latter does not redefine it.  I feared 
changing "#ifdef CC1_SPEC ... #endif" to "#undef CC1_SPEC" would break 
other targets -- there are too many of them and the dependencies are too 
scattered for me to dare fiddling with this macro (proof-reading is futile 
and testing every configuration impossible).  At least this change is 
guaranteed to affect only Linux.  But I would encourage you, as the 
maintainer, to get a more consistent general arrangement and I can do 
testing for configurations I have access to.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>