[Top] [All Lists]

Re: [PATCH] macsonic/jazzsonic drivers update

To: Jeff Garzik <>
Subject: Re: [PATCH] macsonic/jazzsonic drivers update
From: Finn Thain <>
Date: Mon, 27 Jun 2005 22:59:47 +1000 (EST)
Cc: Thomas Bogendoerfer <>, Ralf Baechle <>, Geert Uytterhoeven <>, Linux/m68k <>, Linux/m68k on Mac <>, Linux MIPS <>, Linux net <>
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <> <> <> <> <> <> <> <> <> <> <>

On Sun, 26 Jun 2005, Jeff Garzik wrote:

> Patch looks OK to me.  Comments:
> 1) Either Geert or Ralf can merge this, with my ACK.
> 2) Would be nice to get it tested on the machines you list as untested.
> 3) [possible problem in driver, not your changes] I wonder if IRQ_HANDLED is
> ever returned for shared interrupts?  I don't know enough about the platform
> interrupt architecture to answer this question.

I don't know about jazz machines, but macsonic uses one of two IRQs, and 
neither one can be shared.

> 4) Remove casts to/from void.  This is especially noticable in all the casts
> of the netdev_priv() return value.

OK. I'll wait to hear from the other interested parties and if there's no 
objection to the first patch, I'll post a second patch that just removes 
the unecessary casts.

Thanks for your review.


> 5) If it doesn't cause too much patch noise, consider using enums rather than
> #defines, for numeric constants.  This gives the compiler more type
> information and makes the symbols visible in a debugger.  This is a
> -maintainer preference- issue overall, so don't sweat it if you disagree.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to
> More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>