linux-mips
[Top] [All Lists]

Re: Member sc_sigset gone in latest 2.6.12-rc5 breaks strace.

To: Ton Truong <ttruong@broadcom.com>
Subject: Re: Member sc_sigset gone in latest 2.6.12-rc5 breaks strace.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 9 Jun 2005 23:01:47 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20050609204937.GK4927@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20050606121640.GB6651@linux-mips.org> <200506091737.KAA22310@mon-irva-10.broadcom.com> <20050609204937.GK4927@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Thu, Jun 09, 2005 at 09:49:37PM +0100, Ralf Baechle wrote:

> > I see that in the rc5 update, MIPS codes have now dropped 
> > sc_sigset[4] from struct sigcontext, defined in asm-mips/sigcontext.h.  I'd
> > appreciate it if someone provide a brief summary of what needs to be changed
> > for strace to compile or where I can find an strace port that work with the
> > new MIPS codes?
> 
> sc_sigset and the other members that were changed have been unused by the
> kernel since a very, very long time so whatever strace may have done with
> that field was probably bogus.
> 
> Thanks for reporting, something I'm going to look at tomorrow.

Ok, it was just too trivial.  Here's an untested patch.

  Ralf

 signal.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: strace-cvs/signal.c
===================================================================
--- strace-cvs.orig/signal.c    2005-06-09 22:56:14.000000000 +0100
+++ strace-cvs/signal.c 2005-06-09 22:56:27.000000000 +0100
@@ -1420,7 +1420,7 @@
                if (umove(tcp, sp, &sc) < 0)
                        return 0;
                tcp->u_arg[0] = 1;
-               tcp->u_arg[1] = sc.sc_sigset;
+               tcp->u_arg[1] = &sc + 1;
        } else {
                tcp->u_rval = tcp->u_error = 0;
                if(tcp->u_arg[0] == 0)

<Prev in Thread] Current Thread [Next in Thread>