linux-mips
[Top] [All Lists]

Re: fpu, preempt, ptrace

To: linux-mips@linux-mips.org
Subject: Re: fpu, preempt, ptrace
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Wed, 11 May 2005 00:06:20 +0900 (JST)
Cc: ralf@linux-mips.org
In-reply-to: <20050510.121038.111209401.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20050510.121038.111209401.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
>>>>> On Tue, 10 May 2005 12:10:38 +0900 (JST), Atsushi Nemoto 
>>>>> <anemo@mba.ocn.ne.jp> said:

anemo> For now, get_fpu_regs() is used in ptrace code only and the
anemo> condition 'tsk == current' should always be false.  So we can
anemo> just remove _save_fp() call instead of disabling preemption.

The get_fpu_regs() fix was insufficient.  The caller of the function
should disable preemption.  And while the caller (sys_ptrace) never
pass 'current' to the function, it should be preempt-safe anyway.
Please ignore that part of my patch.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>