linux-mips
[Top] [All Lists]

Re: CVS Update@linux-mips.org: linux

To: linux-mips@linux-mips.org
Subject: Re: CVS Update@linux-mips.org: linux
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Fri, 25 Feb 2005 16:48:06 +0000 (GMT)
In-reply-to: <20050225131124Z8225457-1340+3673@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20050225131124Z8225457-1340+3673@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 25 Feb 2005 ths@linux-mips.org wrote:

> Modified files:
>       arch/mips/mm   : pg-sb1.c 
> 
> Log message:
>       Fix initialization. Unbreak the wait-for-completion loops. Code cleanup.

 Don't use a cast on IOADDR() -- it already returns "void *".  The casts 
obfuscate code and make it difficult to spot incorrect use if the API ever 
changes.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>