linux-mips
[Top] [All Lists]

Re: [patch] generate error when trying to compile PCMCIA driver without

To: Ulrich Eckhardt <eckhardt@satorlaser.com>
Subject: Re: [patch] generate error when trying to compile PCMCIA driver without 64 bit addresses
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 23 Feb 2005 11:19:18 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <200502230947.53588.eckhardt@satorlaser.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200502230947.53588.eckhardt@satorlaser.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Wed, Feb 23, 2005 at 09:47:53AM +0100, Ulrich Eckhardt wrote:

> PCMCIA controller registers are mapped in an area that requires the upper 
> four 
> of the 36 bit addresses, so this can't work without 64 bit physical address 
> support. Sick thing is that due to some stupid casts the whole thing compiles 
> without warnings even without 64 bit support but of course doesn't run. 
> However, that's a topic for a different patch.

> +#if !defined(CONFIG_64BIT_PHYS_ADDR)
> +#  error "need 64bit physical address support to access PCMCIA controller"
> +#endif
> +
>  #define AU1000_PCMCIA_POLL_PERIOD    (2*HZ)
>  #define AU1000_PCMCIA_IO_SPEED       (255)
>  #define AU1000_PCMCIA_MEM_SPEED      (300)

No.  In drivers/pcmcia/Kconfig do something like:

config PCMCIA_AU1X00
        tristate "Au1x00 pcmcia support"
        select 64BIT_PHYS_ADDR
        depends on SOC_AU1X00 && PCMCIA

  Ralf

<Prev in Thread] Current Thread [Next in Thread>