Re: [patch] generate error when trying to compile PCMCIA driver without 64 bit addresses

[Ralf Baechle <ralf@linux-mips.org>]

On Wed, Feb 23, 2005 at 09:47:53AM +0100, Ulrich Eckhardt wrote:

> PCMCIA controller registers are mapped in an area that requires the upper 
> four 
> of the 36 bit addresses, so this can't work without 64 bit physical address 
> support. Sick thing is that due to some stupid casts the whole thing compiles 
> without warnings even without 64 bit support but of course doesn't run. 
> However, that's a topic for a different patch.

> +#if !defined(CONFIG_64BIT_PHYS_ADDR)
> +#  error "need 64bit physical address support to access PCMCIA controller"
> +#endif
> +
>  #define AU1000_PCMCIA_POLL_PERIOD    (2*HZ)
>  #define AU1000_PCMCIA_IO_SPEED       (255)
>  #define AU1000_PCMCIA_MEM_SPEED      (300)

No.  In drivers/pcmcia/Kconfig do something like:

config PCMCIA_AU1X00
        tristate "Au1x00 pcmcia support"
        select 64BIT_PHYS_ADDR
        depends on SOC_AU1X00 && PCMCIA

  Ralf