linux-mips
[Top] [All Lists]

Re: Fixes to MTD flash driver on AMD Alchemy db1100 board

To: linux-mips@linux-mips.org
Subject: Re: Fixes to MTD flash driver on AMD Alchemy db1100 board
From: Ulrich Eckhardt <eckhardt@satorlaser.com>
Date: Tue, 22 Feb 2005 16:32:53 +0100
In-reply-to: <421ADE76.5020905@embeddedalley.com>
Organization: Sator Laser GmbH
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1108962105.6611.24.camel@SillyPuddy.localdomain> <1109052412.20045.6.camel@SillyPuddy.localdomain> <421ADE76.5020905@embeddedalley.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.7.1
Pete Popov wrote:
> Here is a 2.6 patch that gets rid of all the Au1x mapping files and
> replaces them with a single file. 

Big step forward, this looks much cleaner and easier to maintain!

Just a few nits:

1. mymtd = do_map_probe("cfi_probe", &alchemy_map);

Doesn't this mean that the Alchemy flash driver depends on the CFI interface? 
I also see that CONFIG_MTD_CFI is not set in the configfiles for some boards.

2. If above do_map_probe() returns NULL, the ioremap()ed memory is leaked. 
Doesn't matter that much probably, but is trivial to fix.

 if (!mymtd)
 {
  iounmap( alchemy_map.virt);
  return -ENXIO;
 }

3. No need to cast the parameter to iounmap(), it should happily digest 
whatever ioremap() returns. If that gives warnings, something different is 
going wrong in between. ;)


I finally figured out that my board is based largely on db1100, but the 
on-board flash in particular isn't, it's just one 16MBit chip on board. Also, 
the access width is 16 bit and not 32. Seems like I'm going to introduce 
another board type TTP1100...

One more question on the partition layout: is this a real hardware property or 
is this just convention? Can't I configure the flash as I want to?


I'm making progress, thank you all!

Uli

<Prev in Thread] Current Thread [Next in Thread>