Another two suggestions:
- you hard-coded the used display in au1100fb.{h,c} with #ifdef CONFIG_WWPC.
There is another option already used in arch/mips/au1000/common/setup.c, and
that is to append the necessary lines to the kernel commandline if no
conflicting arguments are present.
- I have removed the comments that say to which field a constant belongs and
instead converted au1100fb.h to use new-style initialisers which is just
easier to not get wrong. I also added parameters for my display and replaced
the #define for uint32. The new file is attached as whole, I didn't know
against what to diff it...
Could you merge the file and resend the patch? I hope it will get committed
then.
Uli
au1100fb.h
Description: Text Data
|