linux-mips
[Top] [All Lists]

Re: [PATCH 2.6.11-rc1] add local_irq_enable() to cpu_idle()

To: "Kevin D. Kissell" <kevink@mips.com>
Subject: Re: [PATCH 2.6.11-rc1] add local_irq_enable() to cpu_idle()
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 17 Jan 2005 22:31:00 +0100
Cc: Yoichi Yuasa <yuasa@hh.iij4u.or.jp>, linux-mips <linux-mips@linux-mips.org>
In-reply-to: <41EBEEFA.6040701@mips.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20050118014958.1d9e484e.yuasa@hh.iij4u.or.jp> <41EBEEFA.6040701@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Mon, Jan 17, 2005 at 05:59:38PM +0100, Kevin D. Kissell wrote:

> There have been times when having local_irq_enable() in my idle loop
> would have prevented a hang in some of my experimental kernels, too,
> but it's always been because I had screwed up somewhere else and
> forgotten to re-enable interrupts.  Is there some good reason why
> the kernel should end up in idle with interrupts turned off?

No, never.  It'd result in the scheduler being called with interrupts
disabled which depending if you're lucky or not may happen to reenable
interrupts or not, so you're outside of defined behaviour starting that
point.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>