linux-mips
[Top] [All Lists]

Re: [PATCH] I/O helpers rework

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] I/O helpers rework
From: "Maciej W. Rozycki" <macro@mips.com>
Date: Mon, 10 Jan 2005 18:11:14 +0000 (GMT)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, macro@linux-mips.org
In-reply-to: <20050111.022138.25909508.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.61.0412151936460.14855@perivale.mips.com> <20050107.004521.74752947.anemo@mba.ocn.ne.jp> <Pine.LNX.4.61.0501101503020.18023@perivale.mips.com> <20050111.022138.25909508.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 11 Jan 2005, Atsushi Nemoto wrote:

> Well, maybe the 'volatile' have no sense, but some archs (including
> i386, of course :-)) and some drivers use it.  Adding the 'volatile'
> will remove some compiler warnings.

 As will removing "volatile" from broken ports.

> Yes, virt-to-phys conversion might be needed, but if we only use KSEG1
> for I/O port/memory, it does not matter.

 ioremap() is free to return a KSEG2 address on a 32-bit system.  With 
64-bit systems there is no problem.

> And I have some custom boards which really needs different swapping
> properties (PCI regions need SWAP_IO_SPACE, but ISA region does not,
> for example).  I agree that those boards were misdesigned but I want
> to run Linux on it without modifying existing drivers.

 Hmm, that's strange -- does the system glue ISA otherwise than behind a 
PCI-ISA bridge?  So far I've only spotted a single PCI/ISA system wiring 
the buses as "peers", namely the ancient Intel's i82420EX for 486-class 
processors.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>