linux-mips
[Top] [All Lists]

Re: CPHYSADDR in setup.c

To: Franck Bui-Huu <franck.bui-huu@innova-card.com>
Subject: Re: CPHYSADDR in setup.c
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Date: Mon, 10 Jan 2005 15:32:12 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <41E29036.5040902@innova-card.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <41E26267.2090300@innova-card.com> <20050110135828.GB15344@rembrandt.csv.ica.uni-stuttgart.de> <41E29036.5040902@innova-card.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.6+20040907i
Franck Bui-Huu wrote:
> Hi Thiemo
> 
> Thiemo Seufer wrote:
> 
> >That place in setup.c _had_ virt_to_phys before. It fails to build
> >for 64bit code in 32bit objects with reasonably modern toolchains
> >(which means all 64bit kernels currently supported in CVS).
> >
> yes, but can't we modify "virt_to_phys" or "__pa" directly instead of
> adding some new uses of CPHYSADDR in setup.c

We shouldn't. virt_to_phys accepts typesafe addresses, while CPHYSADDR
only juggles the bits of an unsigned long around. Degrading virt_to_phys
to the standard of CPHYSADDR isn't an improvement.


Thiemo

<Prev in Thread] Current Thread [Next in Thread>