linux-mips
[Top] [All Lists]

Re: [PATCH] Avoid compile warnings on Sibyte using 2.6.10-rc3

To: "Steven J. Hill" <sjhill@realitydiluted.com>
Subject: Re: [PATCH] Avoid compile warnings on Sibyte using 2.6.10-rc3
From: Manish Lachwani <mlachwani@mvista.com>
Date: Wed, 15 Dec 2004 19:28:11 -0800
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <41C0FCFD.9010603@realitydiluted.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20041215235632.GA11386@prometheus.mvista.com> <41C0FCFD.9010603@realitydiluted.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.2) Gecko/20040308
Steven J. Hill wrote:

Manish Lachwani wrote:


The attached patch is needed to prevent the compilation warnings that
occur when using 2.6.10-rc3 on Sibyte. Please review

I don't ever see any warning associated with this. Can you provide a
little more information?

-Steve

Hi Steve,

When did you last sync with CVS? There was a change introduced : http://www.linux-mips.org/cvsweb/linux/include/asm-mips/mach-sibyte/cpu-feature-overrides.h.diff?r1=1.1&r2=1.2

There is another #define in include/asm-mips/

#ifdef CONFIG_SMP
#ifndef cpu_icache_snoops_remote_store
#define cpu_icache_snoops_remote_store (cpu_data[0].icache.flags & MIPS_IC_SNOOPS_REMOTE)
#endif
#else
#define cpu_icache_snoops_remote_store  1
#endif

And if running Sibyte in UP mode, cpu_icache_snoops_remote_store is redefined

Thanks
Manish



<Prev in Thread] Current Thread [Next in Thread>