linux-mips
[Top] [All Lists]

Re: [Patch] make 2.4 compile with GCC-3.4.3...

To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Subject: Re: [Patch] make 2.4 compile with GCC-3.4.3...
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Fri, 3 Dec 2004 13:50:49 +0000 (GMT)
Cc: David Daney <ddaney@avtrex.com>, linux-mips@linux-mips.org
In-reply-to: <20041203064017.GE8714@rembrandt.csv.ica.uni-stuttgart.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <69397FFCADEFD94F8D5A0FC0FDBCBBDEF4FA@avtrex-server.hq.avtrex.com> <20041203064017.GE8714@rembrandt.csv.ica.uni-stuttgart.de>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 3 Dec 2004, Thiemo Seufer wrote:

> > -fno-unit-at-a-time prevents GCC from rearranging things in its output thus 
> > preventing
> > the save_static_function() from being separated from its companion.  As far 
> > as I could tell
> > only syscall.c and signal.c need this.
> 
> Ah, I missed that. It's probably better to use the same way as in 2.6,
> that is, to add a jump at the end of save_static_function().

 Note, that I've send a patch for this twice already.  Still no approval, 
though, for whatever (unstated) reason.

> > noinline was not defined for me :( so I removed it.  It seems that in 2.6 
> > it is
> > just #defined to be nothing.  The alternative is to add:
> >  
> > #ifndef noinline
> > #define noinline
> > #endif
> >  
> > to compiler.h as is done in 2.6
> 
> Yes, that's the better idea. gcc-4.0 ff may need it.

 I'll update the patch accordingly and resend.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>