| To: | "Maciej W. Rozycki" <macro@mips.com> |
|---|---|
| Subject: | Re: [PATCH] Label misplacement on an XTLB refill handler split |
| From: | Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de> |
| Date: | Thu, 2 Dec 2004 19:49:30 +0100 |
| Cc: | linux-mips@linux-mips.org |
| In-reply-to: | <Pine.LNX.4.61.0412021746590.15065@perivale.mips.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <Pine.LNX.4.61.0412021746590.15065@perivale.mips.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.6i |
Maciej W. Rozycki wrote:
> Thiemo,
>
> The XTLB refill handler splitter misplaces labels associated with an
> instruction that gets placed in the branch delay slot of the splitting
> branch. Here's an example:
[snip]
> I've fixed it by separating the label mover (and the reloc mover, for
> consistency) and using it to fix up relevant labels. I'll apply it if
> it's OK with you.
[snip]
> @@ -1110,6 +1121,7 @@ static void __init build_r4000_tlb_refil
> i_nop(&f);
> else {
> copy_handler(relocs, labels, split, split + 1, f);
> + move_labels(labels, f, f + 1, -1);
> f++;
> split++;
> }
Thanks for catching this. Please apply.
Thiemo
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] Label misplacement on an XTLB refill handler split, Maciej W. Rozycki |
|---|---|
| Next by Date: | Re: [PATCH] Broadcom SWARM IDE in 2.6, Manish Lachwani |
| Previous by Thread: | [PATCH] Label misplacement on an XTLB refill handler split, Maciej W. Rozycki |
| Next by Thread: | Re: [PATCH] Label misplacement on an XTLB refill handler split, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |