linux-mips
[Top] [All Lists]

Re: [PATCH] 2.4: Preemption fixes for Broadcom DMA Page operations

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] 2.4: Preemption fixes for Broadcom DMA Page operations
From: Manish Lachwani <mlachwani@mvista.com>
Date: Wed, 01 Dec 2004 16:58:19 -0800
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <Pine.LNX.4.58L.0412020041420.20966@blysk.ds.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20041202003308.GA13085@prometheus.mvista.com> <Pine.LNX.4.58L.0412020041420.20966@blysk.ds.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.2) Gecko/20040308
Hi Maciej,

Maciej W. Rozycki wrote:
On Wed, 1 Dec 2004, Manish Lachwani wrote:


The attached patch implements preempt_disable/preempt_enable around the
SB1 DMA page operations. Please review ...


 Why is it needed?

 Also I think these:

-   if [ "$CONFIG_SIBYTE_SB1250" = "y" ]; then
+   if [ "$CONFIG_SIBYTE_BOARD" = "y" ]; then

are unrelated and inaccurate. The devices are internal to the SoCs and not strictly board-dependent. How about:

+   if [ "$CONFIG_SIBYTE_SB1250" = "y" || "$CONFIG_SIBYTE_BCM112X" = "y"]; then

Actually, this makes more sense. I will send a new patch

Thanks
Manish Lachwani


at the very least, or perhaps using reverse dependencies?

 Maciej



<Prev in Thread] Current Thread [Next in Thread>