linux-mips
[Top] [All Lists]

Re: [PATCH] 2.4: Preemption fixes for Broadcom DMA Page operations

To: Manish Lachwani <mlachwani@mvista.com>
Subject: Re: [PATCH] 2.4: Preemption fixes for Broadcom DMA Page operations
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 2 Dec 2004 00:52:04 +0000 (GMT)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20041202003308.GA13085@prometheus.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20041202003308.GA13085@prometheus.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 1 Dec 2004, Manish Lachwani wrote:

> The attached patch implements preempt_disable/preempt_enable around the
> SB1 DMA page operations. Please review ...

 Why is it needed?

 Also I think these:

-   if [ "$CONFIG_SIBYTE_SB1250" = "y" ]; then
+   if [ "$CONFIG_SIBYTE_BOARD" = "y" ]; then

are unrelated and inaccurate.  The devices are internal to the SoCs and 
not strictly board-dependent.  How about:

+   if [ "$CONFIG_SIBYTE_SB1250" = "y" || "$CONFIG_SIBYTE_BCM112X" = "y"]; then

at the very least, or perhaps using reverse dependencies?

 Maciej

<Prev in Thread] Current Thread [Next in Thread>