| To: | "Maciej W. Rozycki" <macro@linux-mips.org> |
|---|---|
| Subject: | Re: CVS Update@-mips.org: linux |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Sun, 28 Nov 2004 00:15:43 +0100 |
| Cc: | sjhill@linux-mips.org, linux-mips@linux-mips.org |
| In-reply-to: | <Pine.LNX.4.58L.0411272202100.12787@blysk.ds.pg.gda.pl> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20041127061929Z8224786-1751+2584@linux-mips.org> <Pine.LNX.4.58L.0411272202100.12787@blysk.ds.pg.gda.pl> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.4.1i |
On Sat, Nov 27, 2004 at 10:05:07PM +0000, Maciej W. Rozycki wrote: > > Log message: > > Clean up comments, add in new module parameter handling to get rid of > > compiler > > warnings and Manish's printk patch for ethernet device names shown in > > email > > (http://www.linux-mips.org/archives/linux-mips/2004-11/msg00116.html). > > Hmm, shouldn't that be: > > if (sc->rx_hw_checksum == ENABLE) > printk(KERN_INFO "%s: enabling TCP rcv checksum\n", > sc->sbm_dev->name); > > Otherwise the report doesn't actually reflect the condition. > > I'll change it thus as obvious. We're already printing way too much stuff and this is a not very useful message so why not removing the whole thing for good ... Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: CVS Update@-mips.org: linux, Maciej W. Rozycki |
|---|---|
| Next by Date: | Re: CVS Update@-mips.org: linux, Maciej W. Rozycki |
| Previous by Thread: | Re: CVS Update@-mips.org: linux, Maciej W. Rozycki |
| Next by Thread: | Re: CVS Update@-mips.org: linux, Maciej W. Rozycki |
| Indexes: | [Date] [Thread] [Top] [All Lists] |