linux-mips
[Top] [All Lists]

Re: [PATCH] Comments in the titan ethernet driver for IP header alignme

To: Manish Lachwani <mlachwani@prometheus.mvista.com>
Subject: Re: [PATCH] Comments in the titan ethernet driver for IP header alignment
From: Thomas Koeller <thomas.koeller@baslerweb.com>
Date: Tue, 23 Nov 2004 19:10:02 +0100
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20041123171421.GA30451@prometheus.mvista.com>
Organization: Basler AG
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20041123171421.GA30451@prometheus.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.6.2
Hi Manish,

register 0x103c is not documented in any but the newest version of
the processor's user manual, and the function documented there has
_nothing_ to do with header alignment. So either the docs are wrong,
or the register implements both the documented and undocumented
functions. In this case, however, the code would be wrong because it
permanently modifies the register's contents, which could screw up
packet priority processing.

Thomas

On Tuesday 23 November 2004 18:14, Manish Lachwani wrote:
> Hi Ralf,
>
> Attached patch puts comments around the section that programs register
> 0x103C for IP header alignment. Please review ...
>
> Thanks
> Manish Lachwani

-- 
--------------------------------------------------

Thomas Koeller, Software Development
Basler Vision Technologies

thomas dot koeller at baslerweb dot com
http://www.baslerweb.com

==============================


<Prev in Thread] Current Thread [Next in Thread>