| To: | "Maciej W. Rozycki" <macro@linux-mips.org> |
|---|---|
| Subject: | Re: titan code question |
| From: | Manish Lachwani <mlachwani@mvista.com> |
| Date: | Mon, 22 Nov 2004 11:42:44 -0800 |
| Cc: | Thomas Koeller <thomas.koeller@baslerweb.com>, linux-mips@linux-mips.org |
| In-reply-to: | <Pine.LNX.4.58L.0411221936220.31113@blysk.ds.pg.gda.pl> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200411191623.14760.thomas.koeller@baslerweb.com> <41A2234C.8090809@mvista.com> <Pine.LNX.4.58L.0411221936220.31113@blysk.ds.pg.gda.pl> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.2) Gecko/20040308 |
Maciej W. Rozycki wrote: On Mon, 22 Nov 2004, Manish Lachwani wrote:Hence, they used this register. I am not sure if this is even documented. However, this code has been written based on the feedback from the chip designers. If you dont use this code, the MAC subsystem of titan will stop aligning IP headers and you will need to implement the code in the driver to do the aligning.That means you should use macros for registers and their contents, preferably with some nearby documentation in the form of comments to clarify less obvious bits. Otherwise you end up with an unmaintainable mess, especially once other sources of information drain out. Maciej I agree that we need to provide documentation :) Thanks Manish Lachwani |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: titan code question, Maciej W. Rozycki |
|---|---|
| Next by Date: | [PATCH] support for au1xxx on-chip usb in BE mode, Herbert Valerio Riedel |
| Previous by Thread: | Re: titan code question, Maciej W. Rozycki |
| Next by Thread: | [PATCH] support for au1xxx on-chip usb in BE mode, Herbert Valerio Riedel |
| Indexes: | [Date] [Thread] [Top] [All Lists] |