linux-mips
[Top] [All Lists]

Re: [PATCH] Synthesize TLB refill handler at runtime

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] Synthesize TLB refill handler at runtime
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Date: Mon, 22 Nov 2004 16:56:31 +0100
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Linux/MIPS Development <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <Pine.LNX.4.58L.0411221428330.31113@blysk.ds.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20041121170242.GR20986@rembrandt.csv.ica.uni-stuttgart.de> <Pine.GSO.4.61.0411212048520.26374@waterleaf.sonytel.be> <20041121203757.GS20986@rembrandt.csv.ica.uni-stuttgart.de> <Pine.LNX.4.58L.0411221428330.31113@blysk.ds.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.6i
Maciej W. Rozycki wrote:
> On Sun, 21 Nov 2004, Thiemo Seufer wrote:
> 
> > Aww, fatal error in the spelling module. :-)
> > Updated.
> 
>  Great stuff!  Thanks a lot.  I gave it some testing on hardware available 
> to me and it works just fine.  I've got a couple of warnings upon 
> building, though:
> 
> arch/mips/mm/tlbex.c:500: warning: 'i_LA' defined but not used
> arch/mips/mm/tlbex.c:568: warning: 'insn_has_bdelay' defined but not used
> arch/mips/mm/tlbex.c:582: warning: 'il_bltz' defined but not used
> arch/mips/mm/tlbex.c:588: warning: 'il_b' defined but not used
> 
> How about marking them "attribute((unused))"?  I can do that if you agree.

Please do so, but IIRC there's a compiler-independent Linux-specific
define which is preferable. Newest gcc just removes unused static
functions without further notice, AFAIK.


Thiemo

<Prev in Thread] Current Thread [Next in Thread>