linux-mips
[Top] [All Lists]

Re: [PATCH] Support for PMC-Sierra Ocelot-3 in 2.6

To: Manish Lachwani <mlachwani@prometheus.mvista.com>
Subject: Re: [PATCH] Support for PMC-Sierra Ocelot-3 in 2.6
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 3 Nov 2004 00:07:33 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20041102201720.GB24674@prometheus.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20041102201720.GB24674@prometheus.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Tue, Nov 02, 2004 at 12:17:20PM -0800, Manish Lachwani wrote:

> +#ifdef CONFIG_MIPS64
> +             0xfffffffffc807000;
> +#else
> +             0xfc807000;
> +#endif

Ouch.  Rather ugly.  I suggest you rely on the implicit sign extension
of the compiler instead.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>