linux-mips
[Top] [All Lists]

Re: [PATCH]Preemption patch for 2.6

To: mlachwani@mvista.com
Subject: Re: [PATCH]Preemption patch for 2.6
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Mon, 25 Oct 2004 00:28:50 +0900 (JST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <1098468403.4266.42.camel@prometheus.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1098468403.4266.42.camel@prometheus.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
>>>>> On 22 Oct 2004 11:06:43 -0700, Manish Lachwani <mlachwani@mvista.com> 
>>>>> said:

mlachwani> The attached patch incorporates preemption enable/disable
mlachwani> in some parts of the kernel. I have tested this on the
mlachwani> Broadcom Sibyte. Please review ...

1. You add preempt_disable/preempt_enable to c-sb1.c and tlb-sb1.c.
   Those are SB1 specific issue?  If not, please fix other c-*.c and
   tlb-*.c same way.

2. fpu_emulator_cop1Handler and save/restore_fp_context contain
   calling of get_user/put_user which is not allowed during preempt
   disabled.  (But it might be a kernel bug.  Please refer recent
   discussion on this ML)  I will post revised patch again.

Anyway, thanks for your fixes.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>