linux-mips
[Top] [All Lists]

Re: [PATCH 2.6.9] KSEG/CKSEG fixes

To: Ladislav Michl <ladis@linux-mips.org>
Subject: Re: [PATCH 2.6.9] KSEG/CKSEG fixes
From: Tom Rini <trini@kernel.crashing.org>
Date: Thu, 21 Oct 2004 07:48:15 -0700
Cc: linux-mips@linux-mips.org
In-reply-to: <20041021070921.GA2297@umax645sx>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20041021001427.GA25441@smtp.west.cox.net> <20041021070921.GA2297@umax645sx>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.6+20040907i
On Thu, Oct 21, 2004 at 09:09:21AM +0200, Ladislav Michl wrote:
> On Wed, Oct 20, 2004 at 05:14:27PM -0700, Tom Rini wrote:
> > The following is needed to get an SB1250 to compile & boot in 64bit
> > mode (briefly tested).
> > 
> > Signed-off-by: Tom Rini <trini@kernel.crashing.org>
> > 
> > --- linux-2.6.9.orig/arch/mips/mm/c-sb1.c
> > +++ linux-2.6.9/arch/mips/mm/c-sb1.c
> > @@ -488,7 +488,11 @@ void ld_mmu_sb1(void)
> >     /* Special cache error handler for SB1 */
> >     memcpy((void *)(CAC_BASE   + 0x100), &except_vec2_sb1, 0x80);
> >     memcpy((void *)(UNCAC_BASE + 0x100), &except_vec2_sb1, 0x80);
> > +#ifdef CONFIG_MIPS64
> > +   memcpy((void *)CKSEG1ADDR(&handle_vec2_sb1), &handle_vec2_sb1, 0x80);
> > +#else
> >     memcpy((void *)KSEG1ADDR(&handle_vec2_sb1), &handle_vec2_sb1, 0x80);
> > +#endif
> 
> I don't think this is best solution. Thomas Bogendoerfer messed with
> KSEG/CKSEG definitions recently and idea is to create board specific
> header file spaces.h

Would this include abstracting the notion of KSEG1/CKSEG1 into something
where one name would get the right var on 32 or 64 ?  If so, is this in
CVS now?  If not, wouldn't it make sense to put this in now and convert
it when the changes do go in?

-- 
Tom Rini
http://gate.crashing.org/~trini/

<Prev in Thread] Current Thread [Next in Thread>