linux-mips
[Top] [All Lists]

Re: [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs

To: "David S. Miller" <davem@davemloft.net>
Subject: Re: [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Date: Thu, 21 Oct 2004 10:47:29 +0200
Cc: Andi Kleen <ak@suse.de>, dhowells@redhat.com, torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org, discuss@x86-64.org, sparclinux@vger.kernel.org, linuxppc64-dev@ozlabs.org, linux-m68k@vger.kernel.org, linux-sh@m17n.org, linux-arm-kernel@lists.arm.linux.org.uk, parisc-linux@parisc-linux.org, linux-ia64@vger.kernel.org, linux-390@vm.marist.edu, linux-mips@linux-mips.org
In-reply-to: <20041020160450.0914270b.davem@davemloft.net>
Mail-followup-to: "David S. Miller" <davem@davemloft.net>, Andi Kleen <ak@suse.de>, dhowells@redhat.com, torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org, discuss@x86-64.org, sparclinux@vger.kernel.org, linuxppc64-dev@ozlabs.org, linux-m68k@vger.kernel.org, linux-sh@m17n.org, linux-arm-kernel@lists.arm.linux.org.uk, parisc-linux@parisc-linux.org, linux-ia64@vger.kernel.org, linux-390@vm.marist.edu, linux-mips@linux-mips.org
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <3506.1098283455@redhat.com> <20041020150149.7be06d6d.davem@davemloft.net> <20041020225625.GD995@wotan.suse.de> <20041020160450.0914270b.davem@davemloft.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.6i
On Wed, 2004-10-20 16:04:50 -0700, David S. Miller <davem@davemloft.net>
wrote in message <20041020160450.0914270b.davem@davemloft.net>:
> On Thu, 21 Oct 2004 00:56:25 +0200
> Andi Kleen <ak@suse.de> wrote:

*VAX hacker's hat on*

> I disagree quite strongly.  One major frustration for users of
> non-x86 platforms is that functionality is often missing for some
> time that we can make trivial to keep in sync.

Full ACK.

> Simply put, if you're not watching the tree in painstaking detail
> every day, you miss all of these enhancements.

Right; and these missing enhancements will cause extra-pain when they're
used some time later from core code. That is, you missed the feature
while it was discusses/accepted and need to put it in place later on. So
you've got to do extra searching etc.

> The knowledge should come from the person putting the changes into
> the tree, therefore it gets done once and this makes it so that
> the other platform maintainers will find out about it automatically
> next time they update their tree.

Here's my proposal:

$ mkdir ./Documentation/new_enhancements_to_implement
$ cat ./Documentation/new_enhancements_to_implement/new_key_syscalls << EOF
> Dear Architecture Maintailers,
> 
> please add these four new cryptographic key functions to your syscall
> table. It's quite easy; just extend the ./include/arch-xxx/unistd.h
> for four new defines and then add them to your ./arch/xxx/kernel/entry.S
> file. For reference, here's my i386 patch doing this:
> 
> diff -Nurp
> --- path-old/to/file/one
> +++ path-new/to/file/one
>  text
> -del
> +add
>  more text
> 
> 
> Thanks, your keychain hacker:-)
> EOF
$

This way, all arch maintainers just *see* what needs to be done and
get a small introduction on how to do that. I'd *really* like to see
that! That would particularly help those that cannot do full-time
hacking on their port (like us VAX hackers:-)

MfG, JBG

-- 
Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481             _ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  _ _ O
 fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!   O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>