Re: [PATCH] Broadcom SWARM IDE driver

["Maciej W. Rozycki" <macro@linux-mips.org>]

On Fri, 15 Oct 2004, Manish Lachwani wrote:

> +       if (!request_region(0x1f0, 0x2ff, "sibyte-ide"))
> +               printk("could not reserve for the Broadcom SWARM IDE 
> port \n");

 This makes no sense, sorry -- the SWARM IDE interface is not I/O-mapped.  
In fact it's not on PCI at all -- it just occupies the 4th slot of the
BCM1250A's generic bus.  You should reserve the iomem area covering the
slot instead.

 The rest appears sane enough for the current excuse for a driver. ;-)

  Maciej