linux-mips
[Top] [All Lists]

Re: meshcube patch for au1000 network driver

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: meshcube patch for au1000 network driver
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 14 Oct 2004 22:13:44 +0200
Cc: Bjoern Riemer <riemer@fokus.fraunhofer.de>, ppopov@embeddedalley.com, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <Pine.GSO.4.61.0410131314040.2571@waterleaf.sonytel.be>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <416BC4D9.2060904@fokus.fraunhofer.de> <20041013110947.GA6992@linux-mips.org> <Pine.GSO.4.61.0410131314040.2571@waterleaf.sonytel.be>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Wed, Oct 13, 2004 at 01:14:22PM +0200, Geert Uytterhoeven wrote:

> On Wed, 13 Oct 2004, Ralf Baechle wrote:
> > On Tue, Oct 12, 2004 at 01:49:45PM +0200, Bjoern Riemer wrote:
> > > i fixed the ioctl support in the net driver to support link detection by
> > >   ifplugd ond maybe netplugd(not tested)
> > > here my patch for
> > > drivers/net/au1000.c
> > 
> > Please never ever send ed-style patches, only unified (-u).  They're
> > totally unreadable and have several technical problems.  And preferbly
> > inline, not attachment.
> 
> And `-p' helps as wel...

True, it makes patches more readable but there seems to be some trouble
with -p and cvs diff and I certaily don't consider the non-use any kind
of reason for rejecting a patch.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>