Re: meshcube patch for au1000 network driver

[Ralf Baechle <ralf@linux-mips.org>]

On Wed, Oct 13, 2004 at 01:14:22PM +0200, Geert Uytterhoeven wrote:

> On Wed, 13 Oct 2004, Ralf Baechle wrote:
> > On Tue, Oct 12, 2004 at 01:49:45PM +0200, Bjoern Riemer wrote:
> > > i fixed the ioctl support in the net driver to support link detection by
> > >   ifplugd ond maybe netplugd(not tested)
> > > here my patch for
> > > drivers/net/au1000.c
> > 
> > Please never ever send ed-style patches, only unified (-u).  They're
> > totally unreadable and have several technical problems.  And preferbly
> > inline, not attachment.
> 
> And `-p' helps as wel...

True, it makes patches more readable but there seems to be some trouble
with -p and cvs diff and I certaily don't consider the non-use any kind
of reason for rejecting a patch.

  Ralf