linux-mips
[Top] [All Lists]

Re: PATCH

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: PATCH
From: Pete Popov <ppopov@embeddedalley.com>
Date: Mon, 11 Oct 2004 09:33:35 -0700
Cc: macro@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20041011.225341.59463723.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1097452888.4627.25.camel@localhost.localdomain> <Pine.LNX.4.58L.0410110126120.4217@blysk.ds.pg.gda.pl> <4169D818.5020802@embeddedalley.com> <20041011.225341.59463723.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla Thunderbird 0.7.3 (X11/20040803)
Atsushi Nemoto wrote:
On Sun, 10 Oct 2004 17:47:20 -0700, Pete Popov <ppopov@embeddedalley.com> said:


ppopov> Clearly a buglet, carried over from 2.4. That section of the
ppopov> code wouldn't even be compiled, since CONFIG_MIPS64 is not
ppopov> defined. I'll remove that and send a new patch. Anything else
ppopov> you see that's suspicious :)?

Hi.  I wonder why following change is needed.


--- include/asm-mips/page.h     20 Aug 2004 12:02:18 -0000      1.44
+++ include/asm-mips/page.h     19 Sep 2004 22:51:29 -0000
@@ -32,7 +32,7 @@
#ifdef CONFIG_PAGE_SIZE_64KB
#define PAGE_SHIFT      16
#endif
-#define PAGE_SIZE      (1UL << PAGE_SHIFT)
+#define PAGE_SIZE      (1L << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))

#ifdef __KERNEL__

It was related to some compiler problem I mentioned to Ralf sometime ago. Perhaps it's not needed anymore, I'll take a look.

Pete

<Prev in Thread] Current Thread [Next in Thread>