linux-mips
[Top] [All Lists]

Re: PATCH

To: ppopov@embeddedalley.com
Subject: Re: PATCH
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Mon, 11 Oct 2004 22:53:41 +0900 (JST)
Cc: macro@linux-mips.org, ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <4169D818.5020802@embeddedalley.com> <1097481328.27818.10.camel@localhost.localdomain>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1097452888.4627.25.camel@localhost.localdomain> <Pine.LNX.4.58L.0410110126120.4217@blysk.ds.pg.gda.pl> <4169D818.5020802@embeddedalley.com>
Sender: linux-mips-bounce@linux-mips.org
>>>>> On Sun, 10 Oct 2004 17:47:20 -0700, Pete Popov <ppopov@embeddedalley.com> 
>>>>> said:

ppopov> Clearly a buglet, carried over from 2.4. That section of the
ppopov> code wouldn't even be compiled, since CONFIG_MIPS64 is not
ppopov> defined. I'll remove that and send a new patch. Anything else
ppopov> you see that's suspicious :)?

Hi.  I wonder why following change is needed.

> --- include/asm-mips/page.h   20 Aug 2004 12:02:18 -0000      1.44
> +++ include/asm-mips/page.h   19 Sep 2004 22:51:29 -0000
> @@ -32,7 +32,7 @@
>  #ifdef CONFIG_PAGE_SIZE_64KB
>  #define PAGE_SHIFT   16
>  #endif
> -#define PAGE_SIZE    (1UL << PAGE_SHIFT)
> +#define PAGE_SIZE    (1L << PAGE_SHIFT)
>  #define PAGE_MASK    (~(PAGE_SIZE-1))
> 
>  #ifdef __KERNEL__

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>