| To: | "Maciej W. Rozycki" <macro@linux-mips.org> |
|---|---|
| Subject: | Re: PATCH |
| From: | Pete Popov <ppopov@embeddedalley.com> |
| Date: | Sun, 10 Oct 2004 17:47:20 -0700 |
| Cc: | Ralf Baechle <ralf@linux-mips.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org> |
| In-reply-to: | <Pine.LNX.4.58L.0410110126120.4217@blysk.ds.pg.gda.pl> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1097452888.4627.25.camel@localhost.localdomain> <Pine.LNX.4.58L.0410110126120.4217@blysk.ds.pg.gda.pl> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla Thunderbird 0.7.3 (X11/20040803) |
Maciej W. Rozycki wrote: On Mon, 10 Oct 2004, Pete Popov wrote:diff -u -r1.13 addrspace.h --- include/asm-mips/addrspace.h 30 Nov 2003 01:52:25 -0000 1.13 +++ include/asm-mips/addrspace.h 19 Sep 2004 22:51:28 -0000 @@ -80,7 +80,11 @@ #define XKSSEG 0x4000000000000000 #define XKPHYS 0x8000000000000000 #define XKSEG 0xc000000000000000 +#if defined(CONFIG_64BIT_PHYS_ADDR) && defined(CONFIG_CPU_MIPS32) +#define CKSEG0 0x80000000 +#else #define CKSEG0 0xffffffff80000000 +#endif #define CKSEG1 0xffffffffa0000000 #define CKSSEG 0xffffffffc0000000 #define CKSEG3 0xffffffffe0000000This looks suspicious, please explain. Clearly a buglet, carried over from 2.4. That section of the code wouldn't even be compiled, since CONFIG_MIPS64 is not defined. I'll remove that and send a new patch. Anything else you see that's suspicious :)? Pete |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
|
| ||