linux-mips
[Top] [All Lists]

Re: PATCH

To: Pete Popov <ppopov@embeddedalley.com>
Subject: Re: PATCH
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Mon, 11 Oct 2004 01:25:58 +0100 (BST)
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
In-reply-to: <4169BCA6.1080102@embeddedalley.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1097428659.4627.10.camel@localhost.localdomain> <Pine.GSO.4.61.0410102000530.5826@waterleaf.sonytel.be> <Pine.LNX.4.58L.0410102004190.4217@blysk.ds.pg.gda.pl> <4169BCA6.1080102@embeddedalley.com>
Sender: linux-mips-bounce@linux-mips.org
On Sun, 10 Oct 2004, Pete Popov wrote:

> > If not, why not use a data type that covers
> > valid offsets only when passing addresses to bus access functions? 
> 
> The attribute and memory pcmcia addresses are just stored in these 
> variables, and then the upper pcmcia stack layer calls ioremap on these 
> addresses. Thus, you need the 36 bit I/O address patch, as well as the 
> tiny pcmcia patch.
> 
> The pcmcia I/O address is ioremapped at the socket driver level. If that 
> was the case with the mem and attribute addresses, I wouldn't need this 
> 64 bit pcmcia patch. But since it's the upper pcmcia layer that ioremaps 
> these addresses, I need to store tham in 64 bit types.

 OK, but then phys_t should be used for ioaddr_t universally, shouldn't
it?  Any architecture can have the controller seen in a 64-bit memory
space, after all.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>