linux-mips
[Top] [All Lists]

Re: Au1100 Serial Driver

To: greg.nutt@cadenux.com
Subject: Re: Au1100 Serial Driver
From: Pete Popov <ppopov@embeddedalley.com>
Date: Sat, 09 Oct 2004 19:38:49 -0700
Cc: linux-mips@linux-mips.org
In-reply-to: <1097074752.9253.17.camel@spudrun>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1097074271.9253.8.camel@spudrun> <1097074752.9253.17.camel@spudrun>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla Thunderbird 0.7.3 (X11/20040803)
Gregory Nutt wrote:

I think I see an error in the serial driver for the Au1100.  In the
function serial8250_isa_init_ports() there is the line:

 up->port.uartclk  = get_au1x00_uart_baud_base();

Shouldn't this be:

 up->port.uartclk  = get_au1x00_uart_baud_base() * 16;

Isn't the UART clock (normally) 16x the baud_base for this (and most)
UARTs?

Also... beware of:

baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16); quot = serial8250_get_divisor(port, baud);
 quot = 0x35; /* FIXME */

For me, 0x35 is not correct.  For me, the above 16x fix eliminates
the need for this kind of FIXME.
Looks like an old hack that someone forgot to revisit :) Thanks for the patch.

Pete

<Prev in Thread] Current Thread [Next in Thread>