Re: Au1100 Serial Driver

[Pete Popov <ppopov@embeddedalley.com>]

Gregory Nutt wrote:

> I think I see an error in the serial driver for the Au1100.  In the
> function serial8250_isa_init_ports() there is the line:
>
>  up->port.uartclk  = get_au1x00_uart_baud_base();
>
> Shouldn't this be:
>
>  up->port.uartclk  = get_au1x00_uart_baud_base() * 16;
>
> Isn't the UART clock (normally) 16x the baud_base for this (and most)
> UARTs?
>
> Also... beware of:
>
>  baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16); 
>  quot = serial8250_get_divisor(port, baud);
>  quot = 0x35; /* FIXME */
>
> For me, 0x35 is not correct.  For me, the above 16x fix eliminates
> the need for this kind of FIXME.
>  
Looks like an old hack that someone forgot to revisit :) Thanks for the 
patch.
Pete