linux-mips
[Top] [All Lists]

Au1100 Serial Driver

To: linux-mips@linux-mips.org
Subject: Au1100 Serial Driver
From: Gregory Nutt <greg.nutt@cadenux.com>
Date: Wed, 06 Oct 2004 08:59:12 -0600
In-reply-to: <1097074271.9253.8.camel@spudrun>
Organization: Cadenux, LLC
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1097074271.9253.8.camel@spudrun>
Reply-to: greg.nutt@cadenux.com
Sender: linux-mips-bounce@linux-mips.org
I think I see an error in the serial driver for the Au1100.  In the
function serial8250_isa_init_ports() there is the line:

  up->port.uartclk  = get_au1x00_uart_baud_base();

Shouldn't this be:

  up->port.uartclk  = get_au1x00_uart_baud_base() * 16;

Isn't the UART clock (normally) 16x the baud_base for this (and most)
UARTs?

Also... beware of:

  baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16); 
  quot = serial8250_get_divisor(port, baud);
  quot = 0x35; /* FIXME */

For me, 0x35 is not correct.  For me, the above 16x fix eliminates
the need for this kind of FIXME.

Greg
-- 
Gregory Nutt <greg.nutt@cadenux.com>
Cadenux, LLC


<Prev in Thread] Current Thread [Next in Thread>