| To: | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Subject: | Re: [Kernel-janitors] [PATCH 2/6] janitor: net/gt96100eth: pci_find_device to pci_get_device |
| From: | Scott Feldman <sfeldma@pobox.com> |
| Date: | Sun, 03 Oct 2004 10:33:29 -0700 |
| Cc: | kernel-janitors@lists.osdl.org, stevel@mvista.com, source@mvista.com, linux-mips@linux-mips.org |
| In-reply-to: | <20041003092942.A28174@infradead.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1096784371.3819.157.camel@sfeldma-mobl2.dsl-verizon.net> <20041003092942.A28174@infradead.org> |
| Reply-to: | sfeldma@pobox.com |
| Sender: | linux-mips-bounce@linux-mips.org |
On Sun, 2004-10-03 at 01:29, Christoph Hellwig wrote: > On Sat, Oct 02, 2004 at 11:19:31PM -0700, Scott Feldman wrote: > > Replace pci_find_device with pci_get_device/pci_dev_put to plug > > race with pci_find_device. > > Shouldn't this use pci_dev_present? No, because the dev pointer is needed later in the code if dev was found. pci_dev_present doesn't return the dev. -scott |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] Kconfig for R5k/RM7k sc, Christopher G. Stach II |
|---|---|
| Next by Date: | Re: [PATCH] Kconfig for R5k/RM7k sc, Thiemo Seufer |
| Previous by Thread: | Re: [Kernel-janitors] [PATCH 2/6] janitor: net/gt96100eth: pci_find_device to pci_get_device, Christoph Hellwig |
| Next by Thread: | [PATCH] Kconfig for R5k/RM7k sc, Christopher G. Stach II |
| Indexes: | [Date] [Thread] [Top] [All Lists] |