Robin H. Johnson wrote:
I've updated the pcmcia driver but haven't pushed the patch in yet. I
cleaned up the debug code but I'll take a look at what you've done too.
This is a general announcement of some work being done to update XXS1500
support to a 2.6 kernel level. Testers welcome.
This isn't ready for CVS inclusion yet, still needs more testing and
validation, but to stop the hordes of people emailing me about it (Hi
Marcel), here it is being publicly announced:
Applies against latest CVS.
- Kconfig stuff for the BCM5222 Dual PHY.
- XXS1500 PCI IRQ stuff
- MTD access to the onboard flash (Pete's code)
- Kconfig stuff for MTD flash
- drivers/pcmcia/au1000_generic.c: cleanup debug code
The rest of the core 2.6 update is on its way, including the 36bit
support, zImage, all the drivers, etc.
- drivers/pcmcia/au1000_xxs1500.c: port to 2.6
- Move include/asm-mips/xxs1500.h to include/asm-mips/mach-xxs1500/xxs1500.h
No warranty on it, I don't trust my PCMCIA code entirely yet.
From the original codebase:
a) au_writel((au_readl(GPIO2_PINSTATE) & ~(1<<14))|(1<<30), GPIO2_OUTPUT);
b) au_writel((au_readl(GPIO2_PINSTATE) | (1<<14))|(1<<30), GPIO2_OUTPUT);
The 1<<14 indicates a specific location to set, and the 1<<30 says to
enable output on that location.
In arch/mips/au1000/xxs1500/board_setup.c, snippet a is commented as
'turn off power'.
In drivers/pcmcia/au1000_xxs1500.c, snippet a is commented as 'turn on
power', and snippet b is commented as 'turn off power'.
Your guess is as good as mine as to which does what.
I've replaced them with two macros:
Due to the number of times they occur.