| To: | Peter Buckingham <peter@pantasys.com> |
|---|---|
| Subject: | Re: [PATCH 2.6] fix mips atomic_lock declaration |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Tue, 14 Sep 2004 02:22:37 +0200 |
| Cc: | linux-mips@linux-mips.org |
| In-reply-to: | <41462025.9070607@pantasys.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <41462025.9070607@pantasys.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.4.1i |
On Mon, Sep 13, 2004 at 03:33:09PM -0700, Peter Buckingham wrote:
> diff -u -r1.36 atomic.h
> --- include/asm-mips/atomic.h 19 Aug 2004 09:54:23 -0000 1.36
> +++ include/asm-mips/atomic.h 13 Sep 2004 21:51:56 -0000
> @@ -26,7 +26,7 @@
> #include <asm/cpu-features.h>
> #include <asm/war.h>
>
> -extern spinlock_t atomic_lock;
> +static spinlock_t atomic_lock;
>
> typedef struct { volatile int counter; } atomic_t;
No. atomic_lock is intentionally undefined, so this patch seems very
broken.
Ralf
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2.6] fix mips atomic_lock declaration, Peter Buckingham |
|---|---|
| Next by Date: | Re: [PATCH 2.6] fix mips atomic_lock declaration, Peter Buckingham |
| Previous by Thread: | [PATCH 2.6] fix mips atomic_lock declaration, Peter Buckingham |
| Next by Thread: | Re: [PATCH 2.6] fix mips atomic_lock declaration, Peter Buckingham |
| Indexes: | [Date] [Thread] [Top] [All Lists] |