linux-mips
[Top] [All Lists]

Re: Should #ifdef __KERNEL__ be added before #include <spaces.h> in asm-

To: Song Wang <wsonguci@yahoo.com>
Subject: Re: Should #ifdef __KERNEL__ be added before #include <spaces.h> in asm-mips/addrspace.h ?
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 20 Aug 2004 14:05:26 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <20040721000356.39366.qmail@web40003.mail.yahoo.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20040721000356.39366.qmail@web40003.mail.yahoo.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Tue, Jul 20, 2004 at 05:03:56PM -0700, Song Wang wrote:

> Should #ifdef _KERNEL__ be added before #include
> <spaces.h> in asm-mips/addrspace.h?
> 
> I think the reason is the same as when you added
> the #ifdef __KERNEL__ before #include <spaces.h>
> for asm-mips/page.h.

Some userspace software is expecting to get PAGE_SHIFT, PAGE_SIZE and
PAGE_MASK to be available in userspace via <asm/page.h>, so I
protected the inclusion of <asm/spaces.h> with __KERNEL__ but left
the definitions of these symbols unprotected.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>