linux-mips
[Top] [All Lists]

Re: cpu_has_llsc cleanup broke compilation.

To: Kaj-Michael Lang <milang@tal.org>
Subject: Re: cpu_has_llsc cleanup broke compilation.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 17 Aug 2004 09:43:07 +0200
Cc: linux-mips <linux-mips@linux-mips.org>
In-reply-to: <001901c48427$6272acd0$54dc10c3@amos>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <001901c48427$6272acd0$54dc10c3@amos>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Tue, Aug 17, 2004 at 09:56:53AM +0300, Kaj-Michael Lang wrote:

> The "using cpu_has_llsc cleanup all users of ll/sc and lld/scd." broke
> compilation:
> 
>   CC      arch/mips/kernel/offset.s
> In file included from include/asm/bitops.h:35,
>                  from include/linux/bitops.h:4,

Clearly a kernel bug - but one that also shows poor maintenance of your
target.  It should define cpu_has_llsc which it doesn't, so the kernel
will use generic code and deciede at runtime it should use ll/sc.  I'm
fixing this problem but you really should fix your target also.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>