Re: [patch] MIPS/gcc: Revert removal of DImode shifts for 32-bit targets

[Richard Sandiford <rsandifo@redhat.com>]

Richard Henderson <rth@redhat.com> writes:
> On Sat, Aug 07, 2004 at 08:01:43PM +0100, Richard Sandiford wrote:
>> +   do_compare_rtx_and_jump (cmp1, cmp2, cmp_code, true, op1_mode,
>> +                       0, 0, subword_label);
>> + 
>> +   if (!expand_superword_shift (op1_mode, binoptab,
>> +                           outof_input, op1,
>> +                           outof_target, into_target,
>> +                           unsignedp, methods))
>> +     return false;
>
> Return without cleaning up the branch emitted?  In particular,
> doing so without emitting the labels will result in ICEs.

The whole thing's in a sequence that gets discarded if
expand_doubleword_shift returns false.  Isn't that enough?

Richad